How about I change this code in my local dev environment and package it ? Will that be legally OK? I'd do that git hub request in parallel though.
Regards, N.D.
On Mon, Sep 29, 2014 at 1:53 PM, Michael Seiferle ms@basex.org wrote:
Hi N.D.,
feel free to send a pull request on GitHub [1,2]: https://github.com/basexdb/basex
This way we will be able to incorporate your patch into our sources.
Hope this helps and thanks for your contribution,
Michael
[1] https://help.github.com/articles/using-pull-requests [2] http://docs.basex.org/wiki/Git#Using_Git_to_contribute_to_BaseX
On 29 Sep 2014, at 10:05, Nilanjan Dutta wrote:
Hi All,
I want to change/overload the implementation private void Send (Stream s) method in the BaseXClient.cs file. [ basex https://github.com/BaseXdb/basex / basex-api https://github.com/BaseXdb/basex/tree/master/basex-api / src https://github.com/BaseXdb/basex/tree/master/basex-api/src / main https://github.com/BaseXdb/basex/tree/master/basex-api/src/main / c# https://github.com/BaseXdb/basex/tree/master/basex-api/src/main/c%23 / *BaseXClient.cs*]
*Existing implementation:*
private void Send(Stream s) { while (true) { int t = s.ReadByte(); if (t
-1) break; if (t == 0x00 || t == 0xFF) stream.WriteByte(Convert. ToByte(0xFF )); stream.WriteByte(Convert.ToByte(t)); } stream.WriteByte(0); info = Receive(); if(!Ok()) { throw new IOException(info); } } *What I want it to be:* [image: Inline image 1] This one is faster for my use case. Please do let me know how can this be done?
Regards, N.D.
[image.png]